Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests break as new public entries are added to GDC #103

Open
GFJHogue opened this issue Sep 10, 2020 · 0 comments
Open

Integration tests break as new public entries are added to GDC #103

GFJHogue opened this issue Sep 10, 2020 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@GFJHogue
Copy link
Collaborator

Checks in integrations tests such as https://github.com/LincolnSteinLab/gdc-viewer/blob/develop/cypress/integration/ExploreGDC.js#L124 are coupled to total numbers of matching entries and the top results, both of which may change over time.

This leads to unexpected build failures while developing new features (annoying, misleading).
We should find a compromise to decouple tests from these live values while not compromising the integrity of our testing.
@GFJHogue GFJHogue added bug Something isn't working enhancement New feature or request labels Sep 10, 2020
@GFJHogue GFJHogue mentioned this issue Sep 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GFJHogue