Skip to content
This repository has been archived by the owner on Aug 5, 2021. It is now read-only.

Incorrect overload for function called when running test coverage #315

Open
elenadimitrova opened this issue Mar 16, 2020 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@elenadimitrova
Copy link

We have the RegistryModule contract and its isRegisteredModule function here which is being tested here.

When running code coverage the incorrect overload for that function is used, which expects an array or addresses, rather than a single address to be passed in. Sample failing build here

Behaviour as to which overload is selected to run differs between CI and Coverage environments as when running normal unit tests this runs correctly.

elenadimitrova added a commit to argentlabs/argent-contracts that referenced this issue Mar 16, 2020
@ochikov ochikov self-assigned this Mar 16, 2020
@ochikov ochikov added the bug Something isn't working label Mar 16, 2020
elenadimitrova added a commit to argentlabs/argent-contracts that referenced this issue Mar 16, 2020
@ochikov
Copy link
Collaborator

ochikov commented Mar 16, 2020

Thanks for the issue. We are going to investigate it.

elenadimitrova added a commit to argentlabs/argent-contracts that referenced this issue Mar 16, 2020
elenadimitrova added a commit to argentlabs/argent-contracts that referenced this issue Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants