Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent don't delete file when folder is deleted #4059

Merged

Conversation

vitormattos
Copy link
Member

When we delete the LibreSign folder and remove from trash, is necessary to delete LibreSign files too.

@vitormattos vitormattos added this to the Next Major (31) milestone Nov 26, 2024
@vitormattos vitormattos self-assigned this Nov 26, 2024
@vitormattos
Copy link
Member Author

/backport to stable30

@vitormattos
Copy link
Member Author

/backport to stable29

When we delete the LibreSign folder and remove from trash, is necessary
to delete LibreSign files too

Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos vitormattos force-pushed the fix/prevent-do-not-delete-file-when-folder-deleted branch from a029215 to 576b874 Compare November 26, 2024 22:28
@vitormattos vitormattos merged commit 488e410 into main Nov 26, 2024
61 checks passed
@vitormattos vitormattos deleted the fix/prevent-do-not-delete-file-when-folder-deleted branch November 26, 2024 22:39
@backportbot-libresign
Copy link

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/4059/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 576b8742

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4059/stable30

Error: Failed to push branch backport/4059/stable30: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@vitormattos
Copy link
Member Author

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 4. to release
Development

Successfully merging this pull request may close these issues.

1 participant