Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite file list #3746

Merged
merged 48 commits into from
Nov 5, 2024
Merged

feat: rewrite file list #3746

merged 48 commits into from
Nov 5, 2024

Conversation

vitormattos
Copy link
Member

@vitormattos vitormattos commented Sep 20, 2024

@vitormattos vitormattos added this to the Next Major (31) milestone Sep 20, 2024
@vitormattos vitormattos self-assigned this Sep 20, 2024
@vitormattos vitormattos force-pushed the feat/rewrite-file-list branch 5 times, most recently from 3a5376d to 323226d Compare September 23, 2024 23:01
@vitormattos

This comment was marked as resolved.

@vitormattos
Copy link
Member Author

/backport to stable30

@vitormattos
Copy link
Member Author

/backport to stable29

@vitormattos
Copy link
Member Author

vitormattos commented Nov 4, 2024

To think

to-do

  • Make possible delete PDF files and don't only delete the signature request

For now, the the delete feature only delete the signature request, only at LibreSing tables..

I thought in 2 possible ways to solve this but will be necessary to think what's the best:

  1. When confirm to delete a file, put a checkbox to say that want to delete the file too and not only the signature request.
  2. Put two delete options:
    1. Delete signature request
    2. Delete file. When delete file, will also delete the signature request.

PS: I prefer the option 1 more from the previous subject.

Going more deep into other points:

  1. Now, when upload a new file, the file only is added when you define the signer, but the file stay at Nextcloud side. I think that would be good to store at LibreSign side too as draft before to define the signers. With this change will make possible to see and delete a file that was uploaded by LibreSign side.
  • Save file reference in the database as a draft as soon as it is uploaded, before defining who will sign.

At LibreSign menu we have the action "Request". With this PR we also have the request inside action "Files" with the same options (upload new file, request from URL and choose from app Files). Maybe we can remove the action "Request" from main LibreSign menu because sounds as redundant.

My opinion: The "Request" at LibreSign menu sounds more clear and easy to identify how to upload a new file, but... we can implement a first run wizard explaining to an admin account about how to request to sign a file. Would be best to implement a "first run wizard" into a new PR do don't make too complex this PR.

@vitormattos
Copy link
Member Author

To who see this PR:

A point that will make me and everyone involved in the development of LibreSign very happy is if we receive more recurring funding from LibreSign's GitHub Sponsor. This will greatly help to keep the project developing.

If you have any other ideas on how to help the project continue to improve, we would be happy to hear from you: contact@libesign.coop

@Fuseteam
Copy link

Fuseteam commented Nov 4, 2024

I thought in 2 possible ways to solve this but will be necessary to think what's the best:

1. When confirm to delete a file, put a checkbox to say that want to delete the file too and not only the signature request.

2. Put two delete options:
   
   1. Delete signature request
   2. Delete file. When delete file, will also delete the signature request.

I agree that option 1 would be easier UX to most users, it is also very similar to how whatsapp handles "delete media" in chats

p.s.
unfortunately i'm not in a position to able to do a donation

vitormattos and others added 22 commits November 5, 2024 16:20
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Victor Bianchi <vbianchi@protonmail.com>
Signed-off-by: Victor Bianchi <vbianchi@protonmail.com>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Victor Bianchi <vbianchi@protonmail.com>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
We haven't this status implemented yet

Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos vitormattos merged commit 462f9eb into main Nov 5, 2024
57 checks passed
@vitormattos vitormattos deleted the feat/rewrite-file-list branch November 5, 2024 20:17
@vitormattos vitormattos removed this from the Next Major (31) milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 4. to release
Development

Successfully merging this pull request may close these issues.

3 participants