Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] chore: Rename request sign tab #2646

Merged
merged 1 commit into from
Apr 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Components/File/AppFilesTab.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,18 @@
<h3 v-if="filesStore.getSubtitle()">
{{ filesStore.getSubtitle() }}
</h3>
<RequestSignature />
<RequestSignatureTab />
</div>
</template>

<script>
import RequestSignature from '../Request/RequestSignature.vue'
import RequestSignatureTab from '../Request/RequestSignatureTab.vue'
import { useFilesStore } from '../../store/files.js'

export default {
name: 'AppFilesTab',
components: {
RequestSignature,
RequestSignatureTab,
},
setup() {
const filesStore = useFilesStore()
Expand Down
13 changes: 9 additions & 4 deletions src/Components/File/RightSidebar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,27 +7,29 @@
<NcAppSidebarTab v-if="fileName"
id="request-signature-list-signers"
:name="fileName">
<RequestSignature />
<RequestSignatureTab />
</NcAppSidebarTab>
</NcAppSidebar>
</template>

<script>
import NcAppSidebar from '@nextcloud/vue/dist/Components/NcAppSidebar.js'
import NcAppSidebarTab from '@nextcloud/vue/dist/Components/NcAppSidebarTab.js'
import RequestSignature from '../Request/RequestSignature.vue'
import RequestSignatureTab from '../Request/RequestSignatureTab.vue'
import { useFilesStore } from '../../store/files.js'
import { useSignStore } from '../../store/sign.js'

export default {
name: 'RightSidebar',
components: {
NcAppSidebar,
NcAppSidebarTab,
RequestSignature,
RequestSignatureTab,
},
setup() {
const filesStore = useFilesStore()
return { filesStore }
const signStore = useSignStore()
return { filesStore, signStore }
},
computed: {
fileName() {
Expand All @@ -44,6 +46,9 @@ export default {
},
},
methods: {
showListSigners() {
return !!this.filesStore.getFile()?.name
},
closeSidebar() {
this.filesStore.selectFile()
this.$emit('close')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ import { useFilesStore } from '../../store/files.js'
import { useSignStore } from '../../store/sign.js'

export default {
name: 'RequestSignature',
name: 'RequestSignatureTab',
components: {
NcActionButton,
NcButton,
Expand Down