Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small UI fixes #2253

Merged
merged 11 commits into from
Feb 2, 2024
Merged

Small UI fixes #2253

merged 11 commits into from
Feb 2, 2024

Conversation

hugouke
Copy link
Contributor

@hugouke hugouke commented Feb 1, 2024

Pull Request Description

Related Issue

Issue Number:

Pull Request Type

Pull request checklist

  • Did you explain or provide a way of how can we test your code ?
  • If your pull request is related to frontend modifications provide a print of before and after screen
  • Did you provide a general summary of your changes ?
  • Try to limit your pull request to one type, submit multiple pull requests if needed
  • I implemented tests that cover my contribution

@hugouke
change buttons to primary type
c736a20 
Signed-off-by: Hugo Nogueira <nogueiradeoliveira@gmail.com>
@hugouke
add 0 in each js actions
9e1e786 
Signed-off-by: Hugo Nogueira <nogueiradeoliveira@gmail.com>
@hugouke
modal title should have weight bold
728549a 
Signed-off-by: Hugo Nogueira <nogueiradeoliveira@gmail.com>
@hugouke
button next in sidbar should have primary type
822fdf8 
Signed-off-by: Hugo Nogueira <nogueiradeoliveira@gmail.com>
@hugouke
add border to make visible the end of pages
6fae8f7 
Signed-off-by: Hugo Nogueira <nogueiradeoliveira@gmail.com>
@hugouke
when upload from url fail should show error to user
9dc812a 
Signed-off-by: Hugo Nogueira <nogueiradeoliveira@gmail.com>
@hugouke
show success message when request signs
1c3b80d 
Signed-off-by: Hugo Nogueira <nogueiradeoliveira@gmail.com>
@giovannism20
Copy link
Member

Can u pls provide a screenshot of these changes and also make tasks of the pull request checklist @hugouke ?

@hugouke
fix unit tests
f6281cf 
Signed-off-by: Hugo Nogueira <nogueiradeoliveira@gmail.com>
@hugouke
fix integration tests
3d45d12 
Signed-off-by: Hugo Nogueira <nogueiradeoliveira@gmail.com>
@hugouke
fix integration tests
f05c033 
Signed-off-by: Hugo Nogueira <nogueiradeoliveira@gmail.com>
@hugouke
fix unit tests
ed69389 
Signed-off-by: Hugo Nogueira <nogueiradeoliveira@gmail.com>
@vitormattos
Copy link
Member

/backport to stable28

@vitormattos vitormattos merged commit e28456b into main Feb 2, 2024
37 checks passed
@vitormattos vitormattos deleted the small-ui-fixes branch February 2, 2024 14:31
@backportbot-libresign backportbot-libresign bot mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitormattos vitormattos vitormattos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugouke @giovannism20 @vitormattos