It appears BRD songs don't take into account instrument skill and some no skill, am I reading this wrong?

[mogulbgod]

So I'm currently playing as BRD on a private server and noticed being resisted often although I had a lot of +CHR gear and capped skills for my level. Looking at the various files in 'scripts/actions/spells/songs' I can see where Singing Skill is taken into account but I see no Instrument Skill (ex. scripts/actions/spells/songs/carnage_elegy.lua) but others have no calculations for buff potency that take singing skill and instrument skill as factors for determining potency (ex. scripts/actions/spells/songs/advancing_march.lua).

I'm wondering if I'm reading this wrong or is it being handled someplace else?

[RAIST5150]

Most likely handled in globals/magic.lua

This is only a snippet of what goes on in that file, but it is a spot that specifically focuses on player skill/type (there are other sections relating to day/weather, mob resistances, etc.):

function applyResistanceEffect(actor, target, spell, params)
    local spellFamily = spell:getSpellFamily() or 0
    local skillType   = params.skillType or 0
    local element     = spell:getElement() or 0
    local statUsed    = params.attribute or 0
    local bonusMacc   = params.bonus or 0

    -- GUESS stat if it isnt fed with params.
    if statUsed == 0 then
        if skillType == xi.skill.SINGING then
            statUsed = xi.mod.CHR
        else
            statUsed = xi.mod.INT
        end
    end

[RAIST5150]

Hmmm... there could be a bigger issue in the framework though.

Noticed globals/spells has a file for enhancing songs, but not one for enfeebling songs... and those songs did not appear to show up in the enfeebling magic file either.

May indeed be something there for bigger brains to research/discuss.

[mogulbgod]

Reading through globals/spells/enhancing_songs.lua, it does take into account instrument skill level (which is used to figure out the 'power' variable)

local rangeType = caster:getWeaponSkillType(xi.slot.RANGED)

 if
     rangeType == xi.skill.STRING_INSTRUMENT or
     rangeType == xi.skill.WIND_INSTRUMENT
 then
     singingLvl = singingLvl + rangedLvl
 end

I also think you're right about the enfeebling songs.