Build error C2220

[tourmaline3333]

I had succeed to build 9ef7687.
but I pulled ea52b71 and I fail to build with error C2220 of lua_baseentity.h(1).

Would you help me to build server.
log is bellow.(sorry, my environment is Japanese)

W:\FF11Emu_LandSandBoat\Code\server\src\map\lua\lua_baseentity.h(1): error C2220: 次の警告はエラーとして処理されます
W:\FF11Emu_LandSandBoat\Code\server\src\map\lua\lua_baseentity.h(1): warning C4819: ファイルは、現在のコード ページ (932) で表示できない文字を含んでいます。データの損失を防ぐために、ファイルを Unicode 形式で保存してください。
[39/311] Building CXX object src\map\CMakeFiles\topaz_game.dir\commandhandler.cpp.obj
FAILED: src/map/CMakeFiles/topaz_game.dir/commandhandler.cpp.obj
C:\PROGRA2\MICROS1\2019\COMMUN1\VC\Tools\MSVC\14291.300\bin\Hostx86\x86\cl.exe /nologo /TP -DDEBUGLOGMAP -DSOL_ALL_SAFETIES_ON=1 -DSOL_NO_CHECK_NUMBER_PRECISION=1 -DdsUDPSERV -I......\ext\mysql\include\mysql -I......\ext\mysql\include\mysql.. -I......\ext\zmq\include\zmq -I......\ext\zmq\include\zmq.. -I......\ext\lua\include -I......\ext\lua\include.. -I......\src -I......\ext\filewatch -I......\ext\sol\include -I......\ext\spdlog\include -I......\ext\detour -I......\ext\detour\detour /DWIN32 /D_WINDOWS /GR /EHsc -D_CONSOLE -D_MBCS -DNOMINMAX -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE /Oy- /MP /Oi /GL /Gy /TP /MDd /Zi /Ob0 /Od /RTC1 /GL /fp:fast /WX /W4 /wd4100 /wd4127 /wd4201 /wd4242 /wd4244 /wd4245 /wd4456 /wd4457 /wd4458 /wd4459 /wd4701 /wd4702 /wd4703 /w14254 /w14263 /w14265 /w14287 /we4289 /w14296 /w14311 /w14545 /w14546 /w14547 /w14549 /w14555 /w14619 /w14640 /w14826 /w14905 /w14906 /w14928 /permissive- -std:c++17 /showIncludes /Fosrc\map\CMakeFiles\topaz_game.dir\commandhandler.cpp.obj /Fdsrc\map\CMakeFiles\topaz_game.dir\ /FS -c ......\src\map\commandhandler.cpp
W:\FF11Emu_LandSandBoat\Code\server\src\map\lua\lua_baseentity.h(1): error C2220: 次の警告はエラーとして処理されます
W:\FF11Emu_LandSandBoat\Code\server\src\map\lua\lua_baseentity.h(1): warning C4819: ファイルは、現在のコード ページ (932) で表示できない文字を含んでいます。データの損失を防ぐために、ファイルを Unicode 形式で保存してください。
[40/311] Building CXX object src\map\CMakeFiles\topaz_game.dir\alliance.cpp.obj
[41/311] Building CXX object src\map\CMakeFiles\topaz_game.dir\anticheat.cpp.obj
[42/311] Linking CXX executable ......\topaz_connect.exe
[43/311] Building CXX object src\map\CMakeFiles\topaz_game.dir\attack.cpp.obj
FAILED: src/map/CMakeFiles/topaz_game.dir/attack.cpp.obj
C:\PROGRA2\MICROS1\2019\COMMUN1\VC\Tools\MSVC\14291.300\bin\Hostx86\x86\cl.exe /nologo /TP -DDEBUGLOGMAP -DSOL_ALL_SAFETIES_ON=1 -DSOL_NO_CHECK_NUMBER_PRECISION=1 -DdsUDPSERV -I......\ext\mysql\include\mysql -I......\ext\mysql\include\mysql.. -I......\ext\zmq\include\zmq -I......\ext\zmq\include\zmq.. -I......\ext\lua\include -I......\ext\lua\include.. -I......\src -I......\ext\filewatch -I......\ext\sol\include -I......\ext\spdlog\include -I......\ext\detour -I......\ext\detour\detour /DWIN32 /D_WINDOWS /GR /EHsc -D_CONSOLE -D_MBCS -DNOMINMAX -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE /Oy- /MP /Oi /GL /Gy /TP /MDd /Zi /Ob0 /Od /RTC1 /GL /fp:fast /WX /W4 /wd4100 /wd4127 /wd4201 /wd4242 /wd4244 /wd4245 /wd4456 /wd4457 /wd4458 /wd4459 /wd4701 /wd4702 /wd4703 /w14254 /w14263 /w14265 /w14287 /we4289 /w14296 /w14311 /w14545 /w14546 /w14547 /w14549 /w14555 /w14619 /w14640 /w14826 /w14905 /w14906 /w14928 /permissive- -std:c++17 /showIncludes /Fosrc\map\CMakeFiles\topaz_game.dir\attack.cpp.obj /Fdsrc\map\CMakeFiles\topaz_game.dir\ /FS -c ......\src\map\attack.cpp
W:\FF11Emu_LandSandBoat\Code\server\src\map\lua\lua_baseentity.h(1): error C2220: 次の警告はエラーとして処理されます
W:\FF11Emu_LandSandBoat\Code\server\src\map\lua\lua_baseentity.h(1): warning C4819: ファイルは、現在のコード ページ (932) で表示できない文字を含んでいます。データの損失を防ぐために、ファイルを Unicode 形式で保存してください。
ninja: build stopped: subcommand failed.

[TeoTwawki]

likely your compiler isn't detecting our utf-8 file format, or possibly after making a change when you saved the format has been changed and it doesn't like the new file format. I see it mentioning unicode. Set code page and save as UTF-8 with BOM and try again.

[claywar]

C4819 Translation (in case anyone needs): The file contains characters that cannot be displayed in the current code page (932). Save the file in Unicode format to prevent data loss.

[tourmaline3333]

Thank you for your very quick response.I succeed to build!

I opened with VS code below files,and change encode from "UTF-8" to "UTF-8 with BOM".
-lua_baseentity.cpp
-lua_baseentity.h

Would you merge the change to /origin/base branch.

[TeoTwawki]

I actually added the BOM to our files before, but they are keep getting lost or VS doesn't see them until told.

I also tried to enforce the format https://github.com/LandSandBoat/server/blob/base/.editorconfig#L14 ☹️

[tourmaline3333]

ummm,I do not understand it.
anyone override fille with "UTF-8(no BOM)"?

[TeoTwawki]

I tried to automate what you had to do. it did not work.

[claywar]

I'm a bit concerned that that commit had an impact on the file, since it did not make changes to lua_baseentity at all. Any ideas on how that could have happened?

[zach2good]

I've just merged #4953 into base branch. This MIGHT solve any UTF-8/Unicode character issues during Windows builds.