any issues still running char tables in utf8 after PR 3568 ? #3577
-
|
all tables moved to utf8mb4 in https://github.com/LandSandBoat/server/pull/3568/files |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
|
If you're not already facing client and server crashes due to bad charsets or collation settings, you don't need to do anything. This change was to safeguard against people who somehow manage to set up their DB wrong. I've made the Windows instructions very very clear: But I don't know if the Linux steps need similar clarification. Though, we've never had these sorts of issues reported on Linux, so probably not. EDIT: These crashes were specific to non-ascii NPC names, and npc_list isn't protected so there's no need for a migration |
Beta Was this translation helpful? Give feedback.
-
|
@zach2good I think somewhere in the future we should have checking + correcting the charset of the database and tables as a maintenance option (not a migration) in dbtool. Right now we will have a bunch of tables in utf8 3-byte which have no problem running, but confuse folks like Kain when they see that going forward everything is utf8 4-byte. |
Beta Was this translation helpful? Give feedback.
If you're not already facing client and server crashes due to bad charsets or collation settings, you don't need to do anything. This change was to safeguard against people who somehow manage to set up their DB wrong.
I've made the Windows instructions very very clear:
But I don't know if the Linux steps need similar clarification. Though, we've never had these sorts of issues reported on Linux, so probably not.
EDIT: These crashes were specific to non-ascii NPC names, and npc_list isn't protected so there's no need for a migration