Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request For a Fixed Setting to Be Made Configurable #1197

Open
Paul608085 opened this issue Oct 27, 2024 · 1 comment
Open

Request For a Fixed Setting to Be Made Configurable #1197

Paul608085 opened this issue Oct 27, 2024 · 1 comment

Comments

@Paul608085
Copy link

I have recently been experiencing a problem in LMS with one particular radio station not playing. After posting in the Slimdevices forum, with the help of others I have been able to resolve the issue.

For the particular radio station that was not working for me, this change allowed the station to play correctly and did not break any of the other stations that I and others tried it on. This is the relevant thread:

https://forums.slimdevices.com/forum/user-forums/logitech-media-server/1731558-one-radio-station-works-on-pc-but-not-on-lms

The suggestion is that the part of the file that I edited be made configurable in LMS's GUI so that it is easier for users to change if it causes issues. The change is to the file /usr/share/perl5/Slim/Utils/Misc.pm and is to change the currently fixed UserAgentString of iTunes/4.7.1 to be selectable in the GUI. It appears that provided the UserAgentString includes something other than "iTunes", eg "LMS", it works.

I suggest settings options of:

"iTunes/4.7.1 (Default)"
"LMS/4.7.1"
"Custom (***/4.7.1)" ie change to

Please can this be implemented in the next LMS update?

.

@michaelherger
Copy link
Member

Unfortunately this might prove to be tricky... I know that I've been using the UA string to identify LMS in the past (eg. update checker etc.). We'd have to separate out what UA we use when etc. That's certainly not something we want to do in LMS 9.0. I'd have to think about the most efficient way to do this. Maybe use the fixed one for "system calls" like update checks or whatever, or make the one used to scan radio stations configurable.

See eg. https://github.com/michaelherger/Spotty-Plugin/blob/oauth2/cloud/src/index.ts#L23 or https://github.com/LMS-Community/lms-stats-service/blob/main/api/src/index.ts#L14 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants