Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PDF viewer #178

Open
shaamcom83 opened this issue Jan 6, 2019 · 1 comment
Open

Support for PDF viewer #178

shaamcom83 opened this issue Jan 6, 2019 · 1 comment

Comments

@shaamcom83
Copy link

shaamcom83 commented Jan 6, 2019

Would be good when this plugin be used for previewing and downloading pdfs as well.

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request

Current behavior

Expected behavior

Minimal reproduction of the problem with instructions

My official live example on StackBlitz (based on https://stackblitz.com/edit/angular-modal-gallery-v7) is:

What is the motivation / use case for changing the behavior?

Environment (the most important section to fill very carefully)


- @ks89/angular-modal-gallery version: X.X.X
- Node version: X.X.X  
- npm version: X.X.X  
- Operating System and version:  
- Angular version: X.Y.Z 
- angular-cli version (or SystemJS/Webpack): X.Y.Z 
- I'm using Server Side Rendering with angular-universal: YES/NO
- I'm compiling with mode: DEBUG / PROD / PROD with AOT



Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

Others:

@Ks89
Copy link
Owner

Ks89 commented Jan 6, 2019

Hi!
Honestly I'm not an expert about PDFViewer and how to integrate it into a <div>.

The best way to do this is probably start experimenting a cross browser way to show PDFs in a div with fixed width and height and then try to merge it into the library.

To do this I need help, so a repo with some working examples supporting browsers >= IE11.
Then, if the result is good, I can try to merge it into the library.

I cannot set high priority to this, because I already scheduled the todo list for version 8.0.0.

Would you contribute to this?

@Ks89 Ks89 assigned Ks89 and unassigned Ks89 Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants