Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded fmtlib from 8.1.1 to 11.0.0 to get rid of compile warnings #400

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

Mr-Thack
Copy link
Contributor

Resolves #368 by updating fmtlib to the highest possible version without introducing compiling issues.

Anything higher than 11.0.0 will require some code rewriting.

Signed-off-by: AbdulMuqeet Mohammed <abdulmuqeet.mohammed@yahoo.com>
@Mr-Thack
Copy link
Contributor Author

Sorry, didn't even know that sign off existed.

Copy link
Member

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @Mr-Thack - I vaguely remember updating fmt was causing issues but it seems like the latest version is fully compatible, thank you for the contribution

@axsaucedo axsaucedo merged commit 73f0e28 into KomputeProject:master Nov 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build fails Ubuntu 20.23 - fmt/core.h:1706:15: error: possibly dangling reference to a temporary
2 participants