Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a unique name for CMake build-time-make-directory #395

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Use a unique name for CMake build-time-make-directory #395

merged 2 commits into from
Sep 5, 2024

Commits on Sep 5, 2024

  1. Use a unique name for CMake build-time-make-directory. 

    If CMake calls vulkan_compile_shader multiple times and the shader
directory does not exist in the build directory then
add_custom_target will be called multiple times with a target name of
build-time-make-directory which is not allowed.

Adding the filename of the input file to target name allows this to work
and fixes the build.

Signed-off-by: Robert Quill <robert.quill@imgtec.com>
    @robquill
    robquill committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    7cef8cc View commit details
    Browse the repository at this point in the history

  2. Typo fix 

    Signed-off-by: Robert Quill <robert.quill@imgtec.com>
    @robquill
    robquill committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    d0b2bc0 View commit details
    Browse the repository at this point in the history