Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update headers regenerated from latest xml #264

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

nikhiljnv
Copy link
Contributor

Update OpenCL headers by regenerating them from
latest XML files to include recent spec updates.

Update OpenCL headers by regenerating them from
latest XML files to include recent spec updates.
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - ran the script locally and this matches what I see

@bashbaug
Copy link
Contributor

bashbaug commented Oct 2, 2024

Is this going to need updates to the CTS tests also, for the mutable command buffer changes?

@EwanC
Copy link
Contributor

EwanC commented Oct 2, 2024

Is this going to need updates to the CTS tests also, for the mutable command buffer changes?

I think it's just the code comments that are changing here for mutable command-buffers, so shouldn't be any effect on header users.

@bashbaug
Copy link
Contributor

bashbaug commented Oct 2, 2024

Is this going to need updates to the CTS tests also, for the mutable command buffer changes?

I think it's just the code comments that are changing here for mutable command-buffers, so shouldn't be any effect on header users.

Ah right, thanks! I'll just merge this, then.

@bashbaug bashbaug merged commit 862f06c into main Oct 2, 2024
147 checks passed
@bashbaug bashbaug deleted the header_update_October_2024_release branch October 2, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants