Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake deprecation warning #246

Merged

Conversation

s-barannikov
Copy link
Contributor

Recent versions of CMake issue a deprecation warning:

CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

Silence this warning by using a ...<max> suffix
in cmake_minimum_required invocation.
No functional change intended.

Recent versions of CMake issue a deprecation warning:
```
CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.
```

Silence this warning by using a `...<max>` suffix
in `cmake_minimum_required` invocation.
No functional change intended.
@CLAassistant
Copy link

CLAassistant commented Feb 17, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@MathiasMagnus MathiasMagnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good change.

@bashbaug
Copy link
Contributor

@MathiasMagnus should we be making similar changes to any of our other repos (e.g. OpenCL ICD loader, OpenCL SDK)? If so, how do you want to track this?

@MathiasMagnus
Copy link
Contributor

Our CI/CD changes sport a similar change (and will conflict with this one, but we'll fix), so the other repos will get similar treatment without any special care.

@bashbaug bashbaug merged commit 5945253 into KhronosGroup:main Feb 21, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants