Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Error while starting up webdriver #90

Open
yepyepyepok opened this issue Sep 23, 2023 · 1 comment
Open

[Bug]: Error while starting up webdriver #90

yepyepyepok opened this issue Sep 23, 2023 · 1 comment
Assignees
Labels
backlog Bugs to be fixed in the future bug Something isn't working python Issues or pull requests that concerns Python code

Comments

@yepyepyepok
Copy link

Which program are you seeing this problem on?

Cultured Downloader (exe), Cultured Downloader (py)

Program Version

v4.2.3

Steps to reproduce the bug

  1. Launch program from launcher.py, cultured_downloader.py, or the executable file
  2. Continue with or without changing path
  3. Error occurs: TypeError: ChromeDriverManager.init() got an unexpected keyword argument 'path'

Expected behaviour

The webdriver should have been created without error

Relevant log output (If any)

2023-09-23 17:01:15,161 [Cultured Downloader V4.2.3] [ERROR]:
Uncaught TypeError

Traceback (most recent call last):
File "c:\Users\me\Documents\Cultured-Downloader-python-release\src\launcher.py", line 165, in
cultured_downloader_main()
File "c:\Users\me\Documents\Cultured-Downloader-python-release\src\cultured_downloader.py", line 468, in main
initialise()
File "c:\Users\me\Documents\Cultured-Downloader-python-release\src\cultured_downloader.py", line 462, in initialise
with get_driver(download_path=configs.download_directory) as driver:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "c:\Users\me\Documents\Cultured-Downloader-python-release\src\utils\spinner.py", line 227, in wrapper
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "c:\Users\me\Documents\Cultured-Downloader-python-release\src\utils\web_driver.py", line 108, in get_driver
driver_path = ChromeDriverManager(
^^^^^^^^^^^^^^^^^^^^
TypeError: ChromeDriverManager.init() got an unexpected keyword argument 'path'

Screenshots (Optional)

No response

@yepyepyepok yepyepyepok added the bug Something isn't working label Sep 23, 2023
@KJHJason
Copy link
Owner

This could be fixed by removing the arguments path and cache_valid_range from src\utils\web_driver.py line 109-110. Both of those aren't even part of ChromeDriverManager constructor parameters.

That should be the fix with the latest version of webdriver-manager but I'm currently busy with my internship and also currently starting to focus more on developing the GUI instead of maintaining the python-release branch with the free time I have.
Thus, I will place this in a backlog until I decide to work on a fix for this issue.

On the other hand, you can make a pull request to address this issue if you would like, I can merge it into the python-release branch after reviewing.

@KJHJason KJHJason added backlog Bugs to be fixed in the future python Issues or pull requests that concerns Python code labels Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Bugs to be fixed in the future bug Something isn't working python Issues or pull requests that concerns Python code
Projects
None yet
Development

No branches or pull requests

2 participants