Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridging -- Code review for Pijul Nest #19

Open
notramo opened this issue Dec 2, 2019 · 1 comment
Open

Bridging -- Code review for Pijul Nest #19

notramo opened this issue Dec 2, 2019 · 1 comment
Labels
discussion enhancement New feature or request

Comments

@notramo
Copy link

notramo commented Dec 2, 2019

Pijul is a patch based version control system with better conflict resolution than Git.
There is a social coding platform for Pijul: https://nest.pijul.org/
At the moment there is no code review feature in the Pijul Nest.
Is there any way it could be implemented in Matrix Notepad?
This would require #14 to be completed.
Maybe some server side code would be required (to fetch the patches from the Pijul Nest).
The original content of the patch can't be modified, so every edit should be rendered as a suggestion.
Would this be useful in Matrix Notepad, or it would be feature creep?

@KB1RD KB1RD added discussion enhancement New feature or request labels Dec 2, 2019
@KB1RD
Copy link
Owner

KB1RD commented Dec 2, 2019

@notramo I don't think that this is something that makes sense to implement in Matrix Notepad directly.
BUT...
Matrix Notepad is built on top of Matrix and uses an event-based protocol that can be "spoken" by any program that can receive events from the Matrix server hosting the account. Matrix introduces the concept of bridges, which are designed to allow users from another chat platform to chat with users on Matrix. A bridge could be created that bridges edit events instead of chat messages using the same concept. Using this, the bridge (which would pose as a bot) could create a room and send insertion events for the remote patches. This would allow editing collaboratively through Matrix Notepad.

You mentioned that the original patch cannot be modified. Since Matrix Notepad does not redact old data, the original patch would not be deleted, only not rendered by the client. This is not desirable, though. I am working on multi-branch support as well as per-user branches. The bridge could make it so that all the users are forced into a suggestion branch. Again, the support is not present yet, but that's in the works.

I'll keep the issue open because it should be possible in the future. Bridging is something that I intend to support and I'm excited to see that there is a use for it!

@KB1RD KB1RD changed the title Code review for Pijul Nest Bridging -- Code review for Pijul Nest Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants