Cannot start Docker Compose container after updating image

[Epikest]

original issue

i found the exact change that causes this issue: 7899829
perhaps a reply could be added to the issue as an answer? i fixed it by renaming my folder and adding a new one for plugins:

version: "3.8"
  services:
    archisteamfarm:
      image: justarchi/archisteamfarm
      container_name: archisteamfarm
      environment:
        - ASF_PATH=/archisteamfarm
      volumes:
        - ./archisteamfarm:/archisteamfarm
      ports:
        - 1242:1242
      restart: always
      user: 1001:1001
      pull_policy: always

volumes:
  archisteamfarm:
    external: true

[JustArchi]

You didn't need to find a commit (I know which change caused that), you could just ask why your setup stopped working and I'd be happy to answer it here in calm atmosphere.

The problem was caused by your setup where you've decided to override /asf path in the container with custom files. This is not supported, previously ASF didn't use this folder so this "magically" worked, but with recent versions ASF container puts its own binaries there, and overriding that folder causes direct incompatibility in a way ASF is no longer able to start properly.

You can't assume that you're free to touch every single file and directory in the container. Through the very first version, until now, ASF wiki explains how it's expected to override /app/config, /app/logs and /app/plugins. Nothing in this regard has changed, and this is why it's not a breaking change for majority of people running ASF in containers, since they, as per our guidelines, didn't touch anything outside of /app folder. This applies both, to old containers that still have the old structure, and to the new containers with updated one.

In fact, the change you linked was done precisely to help people avoid shooting themselves in the foot in the future, as I had to deal with people's neglect at least on weekly basis, and after moving ASF binaries in a place nobody is looking at them, there is less chance user accidentally destroys them. This is what happened in your case, since contrary to wiki guidelines you decided to go with custom ASF_PATH and custom location - for no real reason, as you could just override three directories specified above, which would be supported and would not break your setup.

In short, indeed, that was just unlucky coincidence that your folder happened to be in exactly the same place I decided to move ASF binaries to. It's not a bug however, as existing ASF auto-updates would not break your setup (old containers are still using old structure until they're rebuilt), on top of the fact that nobody was expected to put anything there to begin with.

You should also consider fixing your setup, as there is no reason for you to override /archisteamfarm and then put something in /app/plugins from that folder, you can just override /app and you don't even need ASF_PATH for that anymore, as ASF_PATH defaults to /app now.

Even better, you can do exactly what ASF wiki states, and override /app/config, /app/plugins or whatever else you need instead of overriding everything, but even if you decided to override whole /app, that's supported now, and one of the reasons why the commit above was needed, since it wasn't supported before with ASF binaries there (which are now out of the picture hiding in /asf).

[JustArchi]

I've linked this discussion in the issue as per your request by the way.

[Epikest]

i understand why these changes were made. thanks for your help!