Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.7 compatibility #65

Closed
mmiller-max opened this issue Jan 30, 2021 · 3 comments
Closed

1.7 compatibility #65

mmiller-max opened this issue Jan 30, 2021 · 3 comments

Comments

@mmiller-max
Copy link
Member

mmiller-max commented Jan 30, 2021 •
edited
Loading

I'm pretty sure 1.6 is fine (will test when latest PRs are in), but tests seem to be failing on nightly due to some changes with package internals.

1.6 is fine, changes that aren't working come in 1.7
@mmiller-max mmiller-max changed the title Tests failing on nightly 1.7 compatibility Jul 20, 2021
@mmiller-max
Copy link
Member Author

mmiller-max commented Jul 20, 2021 •
edited
Loading

Things that have changed/need fixing

  • Update isinstalled
  • Update gettestfilepath
  • Update imports to remove update_package_test! for v1.7.0
  • Manifest structure has changed - update make_testreports_environment
  • Update use of gen_target_project
  • Fix TestWithProperties test package - seems that we use a different (the released) version of TestReports in this test because it is a dependency of TestWithProperties - Mismatch in TestReports versions when using properties #75
  • Update Complex reference test
  • Check Julia args

@mmiller-max
Copy link
Member Author

WIP PR is #74

@mmiller-max
Copy link
Member Author

Check Julia args moved to #80

1.7 compat closed by #74

@stemann stemann mentioned this issue Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmiller-max