Skip to content

Commit

Permalink
remove suspicious keyword in grid command
Browse files Browse the repository at this point in the history
  • Loading branch information
akabla committed Mar 3, 2024
1 parent 27b92cd commit 9a3f1a3
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions docs/src/assets/plothelper.jl
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ function plotmodel(modelvect; ymaxG = nothing, ymaxJ = nothing)
isnothing(ymaxJ) ? ax1.set_ylim(bottom = -dt, top = ymaxG) : ax1.set_ylim(bottom = -dt)
ax1.tick_params("both", labelsize = 9)
ax1.tick_params(axis="x", which="minor", bottom=true)
ax1.grid(b=true, alpha = 0.2, axis="y", which="major")
ax1.grid(b=true, alpha = 0.2, axis="x", which="major")
ax1.grid(alpha = 0.2, axis="y", which="major")
ax1.grid(alpha = 0.2, axis="x", which="major")

ax2.set_xlabel("Time", fontsize = 10)
ax2.set_ylabel("Strain", fontsize = 10)
Expand All @@ -61,8 +61,8 @@ function plotmodel(modelvect; ymaxG = nothing, ymaxJ = nothing)
isnothing(ymaxJ) ? ax2.set_ylim(bottom = -dt, top = ymaxJ) : ax2.set_ylim(bottom = -dt)
ax2.tick_params("both", labelsize = 9)
ax2.tick_params(axis="x", which="minor", bottom=true)
ax2.grid(b=true, alpha = 0.2, axis="y", which="major")
ax2.grid(b=true, alpha = 0.2, axis="x", which="major")
ax2.grid(alpha = 0.2, axis="y", which="major")
ax2.grid(alpha = 0.2, axis="x", which="major")

= frequencyspec(ω_start = 1e-2, ω_end = 1e2, logstep = log10(1e2/1e-2)/30)

Expand All @@ -76,8 +76,8 @@ function plotmodel(modelvect; ymaxG = nothing, ymaxJ = nothing)
ax3.set_xlabel("Frequency", fontsize = 10)
ax3.set_ylabel("Storage (—) and Loss (- -) moduli", fontsize = 10)
ax3.tick_params("both", labelsize = 9)
ax3.grid(b=true, alpha = 0.2, axis="y", which="major")
ax3.grid(b=true, alpha = 0.2, axis="x", which="major")
ax3.grid(alpha = 0.2, axis="y", which="major")
ax3.grid(alpha = 0.2, axis="x", which="major")
ax3.set_title("Frequency response", fontsize = 10)

return fig
Expand Down

3 comments on commit 9a3f1a3

@moustachio-belvedere
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note b arg documentation here but it defaults to true when kwargs are provided so this change is fine: https://matplotlib.org/3.1.1/api/_as_gen/matplotlib.pyplot.grid.html

@moustachio-belvedere
Copy link
Member

@moustachio-belvedere moustachio-belvedere commented on 9a3f1a3 Mar 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see it in newer documentation though so maybe it was removed and that caused an issue you spotted? https://matplotlib.org/stable/api/_as_gen/matplotlib.pyplot.grid.html

@akabla
Copy link
Member Author

@akabla akabla commented on 9a3f1a3 Mar 3, 2024 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.