A get API #4783
Draft
A get API #4783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4783 +/- ##
==========================================
+ Coverage 89.87% 89.97% +0.10%
==========================================
Files 40 40
Lines 8396 8791 +395
==========================================
+ Hits 7546 7910 +364
- Misses 850 881 +31
☔ View full report in Codecov by Sentry. |
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
|
| @@ -161,13 +163,22 @@ function process_recipe_body!(expr::Expr) | |||
| e = e.args[1] | |||
| end | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| # `$` will be the recommended way to retrieve values | ||
| if e.head === :call && e.args[1] === :(<--) # binary use | ||
| target, attribute = e.args[2], e.args[3] | ||
| expr.args[i] = Expr(:(=), target, :(plotattributes[$RecipesBase.canonical_key($(attribute))])) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| expr.args[i] = Expr(:(=), target, :(plotattributes[$RecipesBase.canonical_key($(attribute))])) | |
| expr.args[i] = Expr( | |
| :(=), | |
| target, | |
| :(plotattributes[$RecipesBase.canonical_key($(attribute))]), | |
| ) |
| target, attribute = e.args[2], e.args[3] | ||
| expr.args[i] = Expr(:(=), target, :(plotattributes[$RecipesBase.canonical_key($(attribute))])) | ||
| elseif e.head === :$ # unary use | ||
| expr.args[i] = :(plotattributes[$RecipesBase.canonical_key($(QuoteNode(only(e.args))))]) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| expr.args[i] = :(plotattributes[$RecipesBase.canonical_key($(QuoteNode(only(e.args))))]) | |
| expr.args[i] = :(plotattributes[$RecipesBase.canonical_key( | |
| $(QuoteNode(only(e.args))), | |
| )]) |
RecipesBase/src/RecipesBase.jl
Outdated
| else | ||
| # if the user has set this keyword, use theirs | ||
| :($RecipesBase.is_explicit(plotattributes, $k) || (plotattributes[$k] = $v)) | ||
| :($RecipesBase.is_explicit(plotattributes, $k) || (plotattributes[$RecipesBase.canonical_key($k)] = $v)) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| :($RecipesBase.is_explicit(plotattributes, $k) || (plotattributes[$RecipesBase.canonical_key($k)] = $v)) | |
| :( | |
| $RecipesBase.is_explicit(plotattributes, $k) || | |
| (plotattributes[$RecipesBase.canonical_key($k)] = $v) | |
| ) |
| @@ -5,9 +5,13 @@ import RecipesBase as RB | |||
| using StableRNGs | |||
| using Test | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| const KW = Dict{Symbol,Any} | ||
|
|
||
| RB.is_key_supported(k::Symbol) = true | ||
| # Reset method table so tests can be rerun (could be more robust) | ||
| recipe_methods = methods(RB.apply_recipe) | ||
| length(recipe_methods) > 2 && Base.delete_method.(methods(RB.apply_recipe)[setdiff(1:end, [1,8])]) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| length(recipe_methods) > 2 && Base.delete_method.(methods(RB.apply_recipe)[setdiff(1:end, [1,8])]) | |
| length(recipe_methods) > 2 && | |
| Base.delete_method.(methods(RB.apply_recipe)[setdiff(1:end, [1, 8])]) |
test/test_args.jl
Outdated
| @test :legend in aliases(:legend_position) | ||
| Plots.add_non_underscore_aliases!(Plots._typeAliases) | ||
| Plots.add_axes_aliases(:ticks, :tick) | ||
| @test getattr(matrixheatmap(reshape(1:12, 3, 4))[1][1], :foreground_color) == RGBA(colorant"red") |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test getattr(matrixheatmap(reshape(1:12, 3, 4))[1][1], :foreground_color) == RGBA(colorant"red") | |
| @test getattr(matrixheatmap(reshape(1:12, 3, 4))[1][1], :foreground_color) == | |
| RGBA(colorant"red") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we don't want to expose the canonical form of an attribute as API, I think a single getter function is a sensible choice here.
Please review carefully as this is going to get public API and there a quite a few subtleties, that we need to define here. E.g. what should
getattr(yaxis, :xlims)return?Open tasks:
<--here for retrieving attributes with alias resolution )Attribution