-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments on JOSSpaper/paper.md #83
Comments
Thank you @zhenwu0728 for your comments. Sorry for the delayed response! I have a question regarding the "better
I am not sure what I should change. Here is my train of thought.
TLDR: Could you clarify/give more details what you think should be changed in response to the "better |
I gave a bit of thought to the issue with julia> F = AIBECSFunction(T, G)
(::SciMLBase.ODEFunction{false, AIBECS.var"#f#438"{Tuple{AIBECS.var"#51#52"{SparseMatrixCSC{Float64, Int64}}}, Vector{Int64}, AIBECS.var"#G#436"{Tuple{typeof(G)}, AIBECS.var"#tracers#434"{Int64, Int64}}, AIBECS.var"#tracer#435"{Int64, Int64}}, LinearAlgebra.UniformScaling{Bool}, Nothing, Nothing, AIBECS.var"#jac#443"{AIBECS.var"#T#440"{Tuple{AIBECS.var"#51#52"{SparseMatrixCSC{Float64, Int64}}}, Int64, Vector{Int64}}, AIBECS.var"#∇ₓG#439"{Tuple{typeof(G)}, Int64, Int64}}, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, typeof(SciMLBase.DEFAULT_OBSERVED), Nothing}) (generic function with 7 methods) and then this julia> F(x,p)
200160-element Vector{Float64}:
1.0
1.0
⋮
1.0
1.0 The Jacobian can be accessed using the SciML syntax: julia> F(Val{:jac},x,p)
200160×200160 SparseMatrixCSC{Float64, Int64} with 3018260 stored entries:
⢿⣷⣄⠀⠀⠀⠀⠀⠀⠀
⠀⠙⢿⣷⣄⠀⠀⠀⠀⠀
⠀⠀⠀⠙⢿⣷⣄⠀⠀⠀
⠀⠀⠀⠀⠀⠙⢿⣷⣄⠀
⠀⠀⠀⠀⠀⠀⠀⠙⢿⣷ But I don't need to have any discussion about the Jacobian and the solvers in the tutorials. So in that sense, having just The steady-state problem is then set up with only julia> prob = SteadyStateProblem(F, x, p)
SteadyStateProblem with uType Vector{Float64}. In-place: false
u0: 200160-element Vector{Float64}:
0.0
0.0
⋮
0.0
0.0 Would that be better in your opinion? |
@zhenwu0728 FYI, there is now an ideal-age tutorial deployed from the linked PR which shows how this looks when using |
Sorry @briochemc I didn't make it clear enough. The But
Yes, if the extra outputs are not used, could they be removed from the |
Comments for openjournals/joss-reviews#3814
I've worked through "ideal age" and "PO4-POP" examples, and they are well documented and informative.
I only have a few minor comments for the package and the paper.
show()
is needed forOCIM2.load()
,F_and_∇ₓF
, etc. Now it's hard to get any useful information from the output.For paper.md:
Taburet_etal_2019
citation is broken.The text was updated successfully, but these errors were encountered: