-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multicomponents #851
Open
epolack
wants to merge
3
commits into
JuliaMolSim:master
Choose a base branch
from
epolack:multicomponents
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Multicomponents #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epolack
force-pushed
the
multicomponents
branch
4 times, most recently
from
April 21, 2023 08:47
68289be
to
e309215
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
epolack
force-pushed
the
multicomponents
branch
13 times, most recently
from
June 22, 2023 12:49
4b3d2f4
to
861982d
Compare
epolack
force-pushed
the
multicomponents
branch
5 times, most recently
from
December 21, 2023 22:14
2a0c5b9
to
1683462
Compare
@mfherbst Could you give me some feedback on this PR? It takes quite some time to keep it up to date with the master branch. |
Understood. I'm pretty busy right now, but I'll do it as soon as I can. |
Sure, Thanks! I just wanted to make sure you had it on your radar :) |
epolack
force-pushed
the
multicomponents
branch
8 times, most recently
from
February 8, 2024 16:40
1345936
to
6434a0c
Compare
epolack
force-pushed
the
multicomponents
branch
8 times, most recently
from
February 26, 2024 09:04
c78f7f7
to
748beed
Compare
epolack
force-pushed
the
multicomponents
branch
from
March 25, 2024 15:20
748beed
to
6ec2f99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API question to settle
TermKinetic.kinetic_energies
,RealSpaceMultiplication.potential
to prevent loops on the components; but maybe in a second time (i.e., future PR). Implementing one at a time needed generalisations?It was what was done for the preconditioner before (e.g., hash 9869eb5)
Remaining points
∅
Future PR
BlochWaves
Base.show
methods); maybe report toψk::BlochWave
.