Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid stop condition in besseli_power_series #115

Open
genmeblog opened this issue Jun 17, 2024 · 1 comment
Open

Invalid stop condition in besseli_power_series #115

genmeblog opened this issue Jun 17, 2024 · 1 comment

Comments

@genmeblog
Copy link

genmeblog commented Jun 17, 2024

Hi,

I believe that arguments in this condition:

Math.check_convergence(t, s) && break

should be reversed, ie Math.check_convergence(s, t) && break

Currently the loop spins 3k times causing slow evaluation.

@heltonmc
Copy link
Member

Thanks for this bug report. This looks like an oversight with the AD translation to Enzyme compatibility. I'll tag @cgeoga to make sure this hasn't percolated through other code bases as well. Need to check all the series that use this function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants