Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can you give a compare with existing implementations? #1

Closed
zsz00 opened this issue Mar 15, 2023 · 2 comments
Closed

can you give a compare with existing implementations? #1

zsz00 opened this issue Mar 15, 2023 · 2 comments

Comments

@zsz00
Copy link

zsz00 commented Mar 15, 2023 •
edited
Loading

I appreciate your excellent work, especially the example https://juliamltools.github.io/shakespeare-gpt

there are some existing implementations of MultiHeadAttention and Transformer:
FluxML/Flux.jl#2146
https://github.com/chengchingwen/NeuralAttentionlib.jl
https://github.com/chengchingwen/Transformers.jl

can you give a compare with existing implementations ?
why you want to implementation this again ?
@JuliaMLTools
Copy link
Owner

Hello! The other version is slow and has an overly complicated interface in my opinion.

@JuliaMLTools
Copy link
Owner

TransformerBlocks.jl is intended to be minimalist and hyper-optimized for performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zsz00 @JuliaMLTools