Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use symbols instead of tb_append, ... #67

Open
CarloLucibello opened this issue Mar 5, 2020 · 2 comments
Open

use symbols instead of tb_append, ... #67

CarloLucibello opened this issue Mar 5, 2020 · 2 comments

Comments

@CarloLucibello
Copy link
Contributor

CarloLucibello commented Mar 5, 2020 •
edited
Loading

:append, :overwrite, ..., seem more convenient to use on the user side than tb_append, tb_overwrite, ...
@PhilipVinc
Copy link
Member

See this comment in #6

Those names sound good, but,
that kind of use of symbols is an antipattern and a holdover from before julia had Enums.

I suggest either Enums or singleton types, if you want to dispatch on it.
Dispatching on it seems over-engineered.
Therefor Enums.

@CarloLucibello
Copy link
Contributor Author

I don't really agree, for this kind of use I would prefer to not pollute namespaces with enums, anyways, no big deal, feel to close this issue or leave it open for further discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PhilipVinc @CarloLucibello