Init script: Added possiblity for overriding JULIAUP_VERSION #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we really want this? My original idea for Juliaup was really that it would always be on the latest version for everyone, and that reproducability would really only come in for Julia itself. We also don't really publish a list of available versions anywhere, or make any guarantees that old versions will hang around. I can see that this might be useful if we ever make a breaking change in Juliaup... |
|
Yeah - it would be nice to avoid accidental breaking changes sneaking in: I got bit by #661 as I relied on setting JULIA_DEPOT_PATH - requiring also setting JULIAUP_DEPOT_PATH: https://github.com/FluxML/Torch.jl/pull/61/files#diff-13bd9d7a30bf46656bc81f1ad5b908a627f9247be3f7d76df862b0578b534fc6R24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should make it possible to customize the juliaup version used, e.g., to lock the juliaup version used for reproducibility in a Dockerfile.