Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make check channel up-to-date in julialauncher optional #706

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

torfjelde
Copy link

As mentioned in #705, the fact that juliaup always prints when an update for the channel in use is available, can sometimes break scripts, etc. which rely on parsing outputs from Julia scripts since this message is also printed to stdout.

This PR adds an option to the config which allows the user to specify whether or not to print the aforementioned warning/info.

I don't really program in Rust, and this was the first time in ages, so I probably didn't implement everything correctly 😬 There might also be an easier way to all of this, but I figured I'd just give it a go.

src/bin/julialauncher.rs Outdated Show resolved Hide resolved
src/bin/juliaup.rs Outdated Show resolved Hide resolved
src/bin/juliaup.rs Outdated Show resolved Hide resolved
src/bin/juliaup.rs Outdated Show resolved Hide resolved
@tamasgal
Copy link

Could we merge this, or does it need more work?

@davidanthoff
Copy link
Collaborator

Wouldn't a much easier solution to this problem simply be to print the update message to the stderr instead of stdout?

@davidanthoff
Copy link
Collaborator

Actually, lets discuss in #705.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants