-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make check channel up-to-date in julialauncher optional #706
Open
torfjelde
wants to merge
6
commits into
JuliaLang:main
Choose a base branch
from
torfjelde:torfjelde/check-channel-update-optional
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Make check channel up-to-date in julialauncher optional #706
torfjelde
wants to merge
6
commits into
JuliaLang:main
from
torfjelde:torfjelde/check-channel-update-optional
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torfjelde
commented
Jul 28, 2023
torfjelde
commented
Jul 28, 2023
torfjelde
commented
Jul 28, 2023
torfjelde
commented
Jul 28, 2023
torfjelde
commented
Jul 28, 2023
torfjelde
commented
Jul 28, 2023
torfjelde
commented
Jul 28, 2023
Could we merge this, or does it need more work? |
Wouldn't a much easier solution to this problem simply be to print the update message to the stderr instead of stdout? |
Actually, lets discuss in #705. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #705, the fact that
juliaup
always prints when an update for the channel in use is available, can sometimes break scripts, etc. which rely on parsing outputs from Julia scripts since this message is also printed to stdout.This PR adds an option to the config which allows the user to specify whether or not to print the aforementioned warning/info.
I don't really program in Rust, and this was the first time in ages, so I probably didn't implement everything correctly 😬 There might also be an easier way to all of this, but I figured I'd just give it a go.