Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileIO compatibility #276

Open
denizyuret opened this issue Jan 18, 2019 · 3 comments
Open

FileIO compatibility #276

denizyuret opened this issue Jan 18, 2019 · 3 comments

Comments

@denizyuret
Copy link

Would it be possible to make JSON compatible with FileIO like JLD or JLD2? Right now I can save/load model files in different formats relying on FileIO figuring out the format looking at file extension and/or magic numbers and would like to do the same with JSON.

@KristofferC
Copy link
Member

I really like how lean and non-bloated JSON.jl is. FileIO has had problems with increasing load times (JuliaPlots/Plots.jl#1379) and also does a lot of questionable stuff like evaluating methods into other packages (https://github.com/JuliaIO/FileIO.jl/blob/a676a5c51fbc0181ebe46348c63cc6de9e09bcae/src/loadsave.jl#L197-L219) and other things that are not really covered by the stability guarantees. JSON.jl is a very important package since e.g. the benchmarking stack uses it which is regularly run on Nightly, so keeping it as stable as possible is useful. There can always be a JSonFileIO package for those that like using FileIO.

@RomeoV
Copy link

RomeoV commented Sep 27, 2024

Maybe it's worth revisiting this with package extensions?
JSON is one of the few formats I've run into that don't support FileIO yet.
EDIT: Seems like e.g. TOML also doesn't support it... Is there a reason for these serialization formats to not be supported that I'm missing?

@RomeoV
Copy link

RomeoV commented Sep 27, 2024

Seems like there's also #366.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants