Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AwkwardArray.is_valid is incomplete #29

Open
jpivarski opened this issue Sep 1, 2023 · 0 comments
Open

AwkwardArray.is_valid is incomplete #29

jpivarski opened this issue Sep 1, 2023 · 0 comments

Comments

@jpivarski
Copy link
Member

It doesn't check rules like, "thou mustn't include an indexed or option-type array directly within another indexed or option-type array" and the complex rules surrounding union composition. (UnionArrays cannot be directly within an indexed or option-type array, and if it's a union of option-type data, the first element of contents must be option-type while all the rest must be UnmaskedArrays.)

I should review all of the rules and encode them into the is_valid function in Julia, so that anything that passes is_valid can be sent to Python without error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant