-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a package and add CUDA support #17
Open
lcw
wants to merge
9
commits into
JuliaArrays:master
Choose a base branch
from
lcw:lcw/cuda
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Accepts primitive types (e.g. types with no fields). This allows broadcast to produce SoA arrays starting from something like `SoA{Float32, 2}`. - Supports multiple storage array types. Most notably `CuArrays` and `CuDeviceArray`.
In this process the broadcasting was updated to work and most of the tests were updated to run.
Here we have updated the README to include the new way of constructing `StructOfArrays` and have removed dated information.
This adds basic support for broadcasting a `StructOfArrays` with `CuArray` storage. I could not figure out how to reuse the functionality from GPUArrays without copying it here.
Open
Why not use StructArrays? |
@cossio I tried, see JuliaArrays/StructArrays.jl#86, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates StructsOfArrays to work with Julia 1.4.1 and turns it into a package. In addition basic CUDA support has been added (thanks @vchuravy!) so that
StructOfArrays
can be passed into kernels, e.g.,and used in broadcasting statements, e.g.,
I first tried to add this functionality to StructArrays.jl but found it hard to get CUDA compatible
getindex
andsetindex!
functions.If this pr gets accepted I would also like to register this as a package. If needed I am happy to help maintain this code.
cc: @vchuravy @simonbyrne