Skipped tests to be shown as skipped in vstest (former showing as suc… #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbeesley
reviewed
Nov 26, 2024
| @@ -38,6 +38,7 @@ public class OverallResult | |||
| public string StdErr { get; private set; } = string.Empty; | |||
| public string StdOut { get; private set; } = string.Empty; | |||
| public bool Success { get; private set; } = false; | |||
| public bool Skipped { get; private set; } = false; | |||
rbeesley
reviewed
Nov 26, 2024
| @@ -96,6 +96,10 @@ public TestResult(Reporter.TestCase testcase, Settings settings, bool combined) | |||
| Duration = _testcase.OverallResult.Duration; | |||
| Name = _testcase.Name; | |||
| Outcome = _testcase.OverallResult.Success ? TestOutcomes.Passed : TestOutcomes.Failed; | |||
| if(testcase.OverallResult.Skipped) | |||
There was a problem hiding this comment.
Likely should be if (_testcase.OverallResult.Skipped). Missing the underscore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testadpater is not carry forwarding the skipped status from the catch2 reporter xml. Instead those skipped tests are shown as success in trx file.
eg:
With this change, the skipped tests are shown as 'Skipped' in Visual studio Test explorer and as "NotExecuted" in generated trx file.
<UnitTestResult executionId="6a3c2627-d0cb-4929-80c5-1fc76c01b68f" testId="59c277a5-ecdc-f576-9efd-6e2ec64fe185" testName="Prototyp-ABC" computerName="xxxxxx" startTime="2024-10-10T10:19:39.1749244+02:00" endTime="2024-10-10T10:19:39.1749244+02:00" testType="13cdc9d9-ddb5-4fa4-a97d-d965ccfc6d4b" outcome="NotExecuted" testListId="8c84fa94-04c1-424b-9868-57a2d4851a1d" relativeResultsDirectory="6a3c2627-d0cb-4929-80c5-1fc76c01b68f">Open Point:
Overall result in trx file does not show skipped tests.
<ResultSummary outcome="Failed"> <Counters total="4" executed="3" passed="1" failed="2" error="0" timeout="0" aborted="0" inconclusive="0" passedButRunAborted="0" notRunnable="0" notExecuted="0" disconnected="0" warning="0" completed="0" inProgress="0" pending="0" />