Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: waitress notification progress bar position is not responsive #54

Open
lz100 opened this issue Jun 2, 2020 · 3 comments
Open

BUG: waitress notification progress bar position is not responsive #54

lz100 opened this issue Jun 2, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@lz100
Copy link

lz100 commented Jun 2, 2020

The progress bar is fixed at a certain window location. It is not responsive. If I scroll or enlarge the window, the progress bar is not moving with the notification bar.

not_moving

I inspected the html and it comfirms:
html
You can see the left, top of notification div is set to auto but the progress bar div is set to a fixed number

This is my code to start waitress

    progress <- Waitress$new(theme = "overlay-opacity",
                             min = 0, max =10)
    progress$notify(
        html = "Validating",
        position = "br",
        text_color = "blue"
        )
# I have some other code to update the loop
# ...

Is this a bug?

@lz100 lz100 changed the title waitress notification progress bar position is not responsive(fixed) waitress notification progress bar position is not responsive Jun 2, 2020
@lz100 lz100 changed the title waitress notification progress bar position is not responsive BUG: waitress notification progress bar position is not responsive Jun 2, 2020
@lz100
Copy link
Author

lz100 commented Jun 2, 2020

I tested with your waitress demo and found the same thing. I think it is not special to my code.
demo_screenshot

I can see the progress bar goes off if I scroll the page when it is running.

@JohnCoene JohnCoene added the bug Something isn't working label Jun 2, 2020
@JohnCoene
Copy link
Owner

Indeed, I had not noticed, thank you for reporting this, I'll look into it.

@lz100
Copy link
Author

lz100 commented Jun 3, 2020

I made some other tests and found that waitress on button has the same issue but a little different.

  1. It is not responsive, if I change the window size while progress bar is running, it has the same issue as above.
  2. Progress bar is set to the highest z-index and it has a separate div that is on top of everything. That means the bar is not inside the parent element containing the button. If I have a collapsable div, when it is collapsed, you would still see the progress bar.
    example
    After collapse
    collapse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants