-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo & udev rules command in README #31
base: master
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis PR fixes documentation issues in the README.md file, specifically addressing a command syntax issue for setting up udev rules and correcting a typo. The main change improves the reliability of the udev rules setup command by using the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rickwierenga - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
sorry, just saw that that is what is in the collapsable. why not make that the default? |
it might also be nice to add
|
with
echo .. | sudo tee
writing is a sudo operation. input redirection uses the user's permission, which might not be sufficient. this change allows easier copy pasteSummary by Sourcery
Documentation: