CryptoExchange update, tp/sl parameters

* CryptoExchange update, added tp/sl parameters perpetual futures order placement, updated ratelimit * Updated reference
JKorf · Jul 2, 2024 · 0d5b5cd · 0d5b5cd
1 parent f5de4ee
commit 0d5b5cd
Show file tree

Hide file tree

Showing 10 changed files with 362 additions and 166 deletions.
diff --git a/BingX.Net/BingX.Net.csproj b/BingX.Net/BingX.Net.csproj
@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks>
     <LangVersion>10.0</LangVersion>
@@ -48,7 +48,7 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="CryptoExchange.Net" Version="7.7.2" />
+    <PackageReference Include="CryptoExchange.Net" Version="7.8.0" />
     <PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

diff --git a/BingX.Net/BingX.Net.xml b/BingX.Net/BingX.Net.xml
diff --git a/BingX.Net/BingXAuthenticationProvider.cs b/BingX.Net/BingXAuthenticationProvider.cs
@@ -7,6 +7,8 @@
 using CryptoExchange.Net.Clients;
 using CryptoExchange.Net.Objects;
 using CryptoExchange.Net.Converters.SystemTextJson;
+using System.Linq;
+using System.Globalization;
 
 namespace BingX.Net
 {
@@ -44,7 +46,12 @@ public override void AuthenticateRequest(
                 parameters.Add("recvWindow", (int)receiveWindow.TotalMilliseconds);
             }
 
-            var parameterSignData = parameters.CreateParamString(true, arraySerialization);
+            string parameterSignData;
+            if (parameterPosition == HttpMethodParameterPosition.InBody)
+                parameterSignData = string.Join("&", parameters.OrderBy(p => p.Key).Select(o => o.Key + "=" + string.Format(CultureInfo.InvariantCulture, "{0}", o.Value)));
+            else
+                parameterSignData = parameters.CreateParamString(true, arraySerialization);
+
             parameters.Add("signature", SignHMACSHA256(parameterSignData, SignOutputType.Hex));
         }
     }

diff --git a/BingX.Net/BingXExchange.cs b/BingX.Net/BingXExchange.cs
@@ -55,7 +55,9 @@ internal BingXRateLimiters()
         private void Initialize()
         {
             RestMarket = new RateLimitGate("Spot Rest Market")
-                                            .AddGuard(new RateLimitGuard(RateLimitGuard.PerHost, new List<IGuardFilter>(), 100, TimeSpan.FromSeconds(10), RateLimitWindowType.Sliding)); // IP limit of 100 requests per 10 seconds in total 
+                                            .AddGuard(new RateLimitGuard(RateLimitGuard.PerHost, new List<IGuardFilter>(), 10, TimeSpan.FromSeconds(1), RateLimitWindowType.Sliding)) // As suggested by BingX API support: IP limit of 10 requests per 1 second in total 
+                                            .AddGuard(new RateLimitGuard(RateLimitGuard.PerHost, new List<IGuardFilter>(), 100, TimeSpan.FromSeconds(10), RateLimitWindowType.Sliding)) // IP limit of 100 requests per 10 seconds in total 
+                                            .AddGuard(new RateLimitGuard(RateLimitGuard.PerHost, new List<IGuardFilter>(), 500, TimeSpan.FromSeconds(60), RateLimitWindowType.Sliding)); // IP limit of 500 requests per 60 seconds in total 
             RestAccount1 = new RateLimitGate("Spot Rest Account 1")
                                             .AddGuard(new RateLimitGuard(RateLimitGuard.PerHost, new List<IGuardFilter>(), 1000, TimeSpan.FromSeconds(10), RateLimitWindowType.Sliding)) // IP limit of 1000 requests per 10 seconds in total 
                                             .AddGuard(new RateLimitGuard(RateLimitGuard.PerEndpoint, new List<IGuardFilter>(), 100, TimeSpan.FromSeconds(10), RateLimitWindowType.Sliding)); // IP limit of 100 requests per 10 seconds per endpoint