You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If a PR is opened which removes the usage of a string and at the same time wants to include a new Github action to ensure instances of the string are not present in future PRs, relying ondiffDoesNotContain parameter will lead to an action failure since the current diff includes deletions of the configured string. Hence, a diffDoesNotAdd parameter that only checks the diff additions for instances of the configured string would be great!
The text was updated successfully, but these errors were encountered:
Hum, I'm checking parse-diff code and that's not an information that's directly in the data parsed from the diff... Best effort here would be to check if the word is in the lines added, but if it was already there, it will make no difference, it will fail anyway. I can check if it's in the lines added and not in the existing lines, however...
If a PR is opened which removes the usage of a string and at the same time wants to include a new Github action to ensure instances of the string are not present in future PRs, relying on
diffDoesNotContain
parameter will lead to an action failure since the current diff includes deletions of the configured string. Hence, adiffDoesNotAdd
parameter that only checks the diff additions for instances of the configured string would be great!The text was updated successfully, but these errors were encountered: