Ultimate Generation Setting Missing

[BickerKFR]

I get an error importing my map on the ultimate generation lobby settings saying they're invalid properties:

		General
		{
			Ultimate Generation: 130%
			Ultimate Generation - Combat: 130%
			Ultimate Generation - Passive: 130%

[ItsDeltin]

Same issue as #239, wrap the general hero settings in a second 'General' object like so:

"General": {
  "General": {
    "Ultimate Generation": 125,
    "Ultimate Generation - Combat": 125,
    "Ultimate Generation - Passive": 126
  }
}

[BickerKFR]

I was trying to use the import function from exactly what the current OW is dumping, it's already wrapped by "heroes". Here's a fuller example if you wanted to try and import it.

settings
{

	lobby
	{
		Allow Players Who Are In Queue: Yes
		Map Rotation: After A Game
		Max Spectators: 12
		Return To Lobby: Never
	}

	heroes
	{
		General
		{
			Ultimate Generation: 10%
			Ultimate Generation - Combat: 0%
			Ultimate Generation - Passive: 0%

			Mercy
			{
				Weapons Enabled: Caduceus Blaster Only
			}
		}
	}

and then after using the command "import from clipboard" the customGameSettings.lobby it creates has in it:

  "Heroes": {
    "General": {
      "Ultimate Generation": 10.0,
      "Ultimate Generation - Combat": 0.0,
      "Ultimate Generation - Passive": 0.0,
      "Mercy": {
        "Weapons Enabled": "Caduceus Blaster Only"
      }
    }
  },

but these Ultimate properties are yellow underlined stating "Property X is not allowed"

Hopefully that is a clearer report now.

[ItsDeltin]

There is a bug where the general hero settings are not placed in it's own section.
That should look like this:

  "Heroes": {
    "General": {
      "General": {
        "Ultimate Generation": 10.0,
        "Ultimate Generation - Combat": 0.0,
        "Ultimate Generation - Passive": 0.0
      },
      "Mercy": {
        "Weapons Enabled": "Caduceus Blaster Only"
      }
    }
  },

The first "General" object affects all teams. The second "General" section are the hero settings that affect all heroes.