Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent use of 'yourprojectnamehere' in 'install-local-migrate.md' #347

Open
McFateM opened this issue Nov 20, 2019 · 3 comments
Open
Assignees
Labels
Documentation Update the docs or kind request for documentation.

Comments

@McFateM
Copy link
Member

McFateM commented Nov 20, 2019

Issue description

As I was working through the 'install-local-migrate.md' document I was confused, more than once, by references to things like "ISLE project". In my case, there were two local ISLE projects:

The local clone of the ICG ISLE repo that I was working from, and
The yourprojectnamehere-isle local directory that I created in Step 2.

Consequently, I'd like to clarify the 'install-local-migrate.md' document with the following changes:

  • Replace vague references to things like "ISLE project", "ISLE repository", or "ISLE directory" with references to 'yourprojectnamehere-isle' or '/path/to/yourprojectnamehere-isle' as appropriate.
  • Use the term "directory" whenever referring to a local entity, and "repository" when referring to a Git repo or similar entity held online.

I would also like to remove the '2. Locate and note...' bullet item under 'Drupal Site Files and Code' in Step 0. It's a little misleading since it tells us to note something, but the instructions never really return to that note. If it's not used explicitly I'd remove it. Change the 1) Copy the... paragraph to a simple bullet.

@McFateM McFateM added the Documentation Update the docs or kind request for documentation. label Nov 20, 2019
McFateM added a commit to McFateM/ISLE that referenced this issue Nov 20, 2019
dwk2 added a commit that referenced this issue Nov 20, 2019
bseeger pushed a commit to bseeger/ISLE that referenced this issue Nov 26, 2019
bseeger pushed a commit to bseeger/ISLE that referenced this issue Nov 26, 2019
@dwk2
Copy link
Member

dwk2 commented Mar 11, 2021

Hi @McFateM, It looks like this issue may now be closed because it was completed in: #348.

Please confirm and close comment if you agree. Thank you!

@SummittDweller
Copy link
Contributor

I'll take you word for it. Thanks.

@dwk2
Copy link
Member

dwk2 commented Mar 11, 2021

@SummittDweller - After looking more carefully, the points you raised in this Issue still remain to be completed. Leaving this issue OPEN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Update the docs or kind request for documentation.
Projects
None yet
Development

No branches or pull requests

3 participants