Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beamChain breaks on horizontal/vertical segments #16

Closed
lopisan opened this issue Oct 30, 2020 · 3 comments · Fixed by #17
Closed

beamChain breaks on horizontal/vertical segments #16

lopisan opened this issue Oct 30, 2020 · 3 comments · Fixed by #17

Comments

@lopisan
Copy link

lopisan commented Oct 30, 2020

Hi,
I've found that beamChain breaks on horizontal and vertical segments of polyline:

When eps is non-zero, it does work:

a=10;
eps=1e-6;
points=[[0, 0, 0], [0+eps, a, 0], [a, a+eps, 0]];
polygon(polyRound( beamChain(points, offset1=1, offset2=-1), 30));

but when eps=0 it breaks (doesn't show anything and sometimes - not always throw a undef error):

a=10;
eps=0;
points=[[0, 0, 0], [0+eps, a, 0], [a, a+eps, 0]];
polygon(polyRound( beamChain(points, offset1=1, offset2=-1), 30));

PS: Thanks for the great library I'm starting with OpenSCAD and I like polyRound very much.

@Irev-Dev
Copy link
Owner

Hey @lopisan,
Thanks for reporting this bug.
Just wanted to let you know I'm busy the weekend, hopefully, I'll get to this early next week.

There's some documentation updates I need to do for beam chain anyway #11, so good extra prompt to get to it.

Glad you like the library 🤗

@Irev-Dev
Copy link
Owner

Irev-Dev commented Nov 2, 2020

Hey @lopisan,
Thanks again for pointing this out, and a well-written bug report.
This should be resolved now, please use the latest version of the code.

Let me know if you have any more issues, or if there's any way I can help you.

Cheers,
Kurt.

@lopisan
Copy link
Author

lopisan commented Nov 2, 2020

Thanks for the fast fix, it is working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants