Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to offer test on ''real'' c3d data ? #79

Open
ANaaim opened this issue Jul 27, 2023 · 4 comments
Open

How to offer test on ''real'' c3d data ? #79

ANaaim opened this issue Jul 27, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@ANaaim
Copy link
Contributor

ANaaim commented Jul 27, 2023

I am aware that c3d data should not be in a git repository : Should we still offer some real c3d data in a outside repertory from which user could download and that they would have to add themselves to a specific repertory ?

==> I think it would definitely allow to offer ''meningfull'' example.

We could use data already available on a open data-set (for example : https://www.nature.com/articles/s41597-019-0124-4)

@Ipuch
Copy link
Owner

Ipuch commented Jul 29, 2023

What is your idea? For which example do you want more meaningful data?

  • one possibility would be to have a data folder.
  • my preferred format would be .trc as we can track changes in lines of code.
  • if c3d is absolutely required, a minimum amount of frame should be considered.
  • enough markers should also be included to anticipate future use in other examples ( e.g. lower limb and upper limb)

@Ipuch Ipuch added the enhancement New feature or request label Jul 29, 2023
@ANaaim
Copy link
Contributor Author

ANaaim commented Sep 13, 2023

https://github.com/mkjung99/biomechanics_dataset

link on data-set we might use ?

@Ipuch
Copy link
Owner

Ipuch commented Sep 13, 2023

Like I said, I'm ok to share a c3d file in data folder with external forces and enough markers in it to perform an inverse kinematics/dynamics example. The example should be written in a way that each separated piece of code should be testable without having to charge the c3d. The c3d should be sharable :)

@ANaaim
Copy link
Contributor Author

ANaaim commented Sep 14, 2023

Ok, I will have to think at what would be a nice example for that. In the end we can do what ever would be needed in my lab. (it could be a silly example...however I think that having a classical gait would be better)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants