Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused iconClassMap option #501

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix unused iconClassMap option #501

wants to merge 1 commit into from

Conversation

MrMicky-FR
Copy link

Currently the iconClassMap option has absolutely no effects, because the values of the built-in iconClassMap variable are directly inlined in the toolbarBuiltInButtons during script initialization which occurs before the constructor call where options are passed.

This PR changes this, by using options.iconClassMap during toolbar creation, which occurs in constructor call

@MrMicky-FR
Copy link
Author

Hi @Ionaru, do you think you could look at this when you have some time ? Because currently the iconClassMap option isn’t working, and this PR fixes this issues and introduced no breaking changes, and the test are passing. Thanks a lot :)

@willGabrielPereira willGabrielPereira mentioned this pull request Oct 13, 2023
Merged
@joeroe joeroe mentioned this pull request Dec 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MrMicky-FR