Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extractYaml option #494

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

faisalraja
Copy link

Handles yaml in front of markdown.

@faisalraja faisalraja mentioned this pull request Aug 24, 2022
@Ionaru
Copy link
Owner

Ionaru commented Aug 30, 2022

Can you add the new extractYaml option to easymde.d.ts?

@faisalraja
Copy link
Author

@Ionaru can you check issue #371
I have a question there, basically maybe it should always just be yaml-frontmatter and when extractYaml is provided, then it's going to remove it from preview? Right now it's also using extractYaml to decide if we'll use yaml-frontmatter.

@Ionaru
Copy link
Owner

Ionaru commented Aug 31, 2022

I think maybe we need to go a step further and always remove the yaml-frontmatter from the preview? Regardless of any option. I don't think there's any situation where you want to see it.

Then a extractYaml function can do something with the data if it wants, otherwise it's just sent as-is to the server.

@faisalraja
Copy link
Author

@Ionaru Makes sense. Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants