Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Praos tests and update for KES #1545

Closed
edsko opened this issue Jan 31, 2020 · 3 comments
Closed

Re-enable Praos tests and update for KES #1545

edsko opened this issue Jan 31, 2020 · 3 comments
Labels
consensus issues related to ouroboros-consensus testing
Milestone
S7 2020-02-27

Comments

@edsko
Copy link
Contributor

edsko commented Jan 31, 2020

No description provided.

@edsko edsko added consensus issues related to ouroboros-consensus shelley testnet testing labels Jan 31, 2020
@edsko edsko mentioned this issue Jan 31, 2020
Merged
@edsko
Copy link
Contributor Author

edsko commented Jan 31, 2020

Alternatively, if the TPraos implementation is parameterized over crypto and can be run with our mock blocks, we could consider removing BFT and Praos entirely, leaving only PBFT and TPraos (PBFT is supported by the mock blocks).

@edsko
Copy link
Contributor Author

edsko commented Feb 18, 2020 •
edited
Loading

Related: IntersectMBO/ouroboros-consensus#714 .

@mrBliss mrBliss mentioned this issue Feb 20, 2020
Merged
@edsko
Copy link
Contributor Author

edsko commented Feb 20, 2020

This will be done as part of #1677 , although it's currently a bit of a hack; see IntersectMBO/cardano-base#81.

edsko added a commit that referenced this issue Feb 20, 2020
@edsko
Re-enable (and fix) the Praos tests
f4eca9d 
Closes #1545
@edsko edsko added this to the S7 2020-02-27 milestone Feb 20, 2020
@iohk-bors iohk-bors bot closed this as completed in e7cfaab Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
consensus issues related to ouroboros-consensus testing
Projects
None yet
Milestone
S7 2020-02-27
Development

No branches or pull requests
1 participant
@edsko