-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documented RatifyState
#4759
Merged
Merged
Documented RatifyState
#4759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
force-pushed
the
jj/ratify-state-docs
branch
from
November 18, 2024 12:13
4a38a96
to
29d8427
Compare
lehins
reviewed
Nov 18, 2024
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Internal.hs
Outdated
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/ratify-state-docs
branch
from
November 19, 2024 10:19
122230c
to
1e926d2
Compare
Soupstraw
force-pushed
the
jj/ratify-state-docs
branch
2 times, most recently
from
November 19, 2024 12:33
3be4f8c
to
8b223f0
Compare
teodanciu
reviewed
Nov 19, 2024
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Internal.hs
Outdated
Show resolved
Hide resolved
teodanciu
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
lehins
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you!
Soupstraw
force-pushed
the
jj/ratify-state-docs
branch
from
November 20, 2024 10:53
8b223f0
to
5dad8ac
Compare
Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
Soupstraw
force-pushed
the
jj/ratify-state-docs
branch
from
November 20, 2024 11:00
5dad8ac
to
f8fb632
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some Haddock comments to
RatifyState
.resolves #4641
Checklist
CHANGELOG.md
for the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)