Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guardrail in Imp genesis #4744

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Guardrail in Imp genesis #4744

merged 6 commits into from
Nov 14, 2024

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Nov 8, 2024

Description

Initialises ImpTests with the current constitution, as published in the Cardano Operations Book

Closes #4726

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu force-pushed the td/guardrail-in-imp-genesis branch 7 times, most recently from bea7654 to b3c19fe Compare November 12, 2024 17:34
@teodanciu teodanciu marked this pull request as ready for review November 12, 2024 17:34
@teodanciu teodanciu requested a review from a team as a code owner November 12, 2024 17:34
@teodanciu teodanciu changed the title Guardrail in imp genesis Guardrail in Imp genesis Nov 13, 2024
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I could only suggest a few minor improvements.

@teodanciu teodanciu merged commit 8a090f2 into master Nov 14, 2024
156 of 159 checks passed
@teodanciu teodanciu deleted the td/guardrail-in-imp-genesis branch November 14, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add guardrails script to the Conway genesis in the imp spec
2 participants