-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guardrail in Imp genesis #4744
Merged
Merged
Guardrail in Imp genesis #4744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
force-pushed
the
td/guardrail-in-imp-genesis
branch
7 times, most recently
from
November 12, 2024 17:34
bea7654
to
b3c19fe
Compare
teodanciu
force-pushed
the
td/guardrail-in-imp-genesis
branch
from
November 13, 2024 12:28
b3c19fe
to
044c329
Compare
teodanciu
force-pushed
the
td/guardrail-in-imp-genesis
branch
from
November 13, 2024 14:45
044c329
to
373c927
Compare
lehins
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I could only suggest a few minor improvements.
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Plutus/Guardrail.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Plutus/Guardrail.hs
Outdated
Show resolved
Hide resolved
and adjust tests to support the fact that a guardrail is enabled
teodanciu
force-pushed
the
td/guardrail-in-imp-genesis
branch
from
November 14, 2024 20:16
373c927
to
338f66a
Compare
teodanciu
force-pushed
the
td/guardrail-in-imp-genesis
branch
from
November 14, 2024 20:31
338f66a
to
5073e61
Compare
lehins
reviewed
Nov 14, 2024
teodanciu
force-pushed
the
td/guardrail-in-imp-genesis
branch
from
November 14, 2024 20:38
5073e61
to
48335ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initialises ImpTests with the current constitution, as published in the Cardano Operations Book
Closes #4726
Checklist
CHANGELOG.md
for the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)