Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compling with later versions of GHC #285

Open
erikd opened this issue Nov 27, 2024 · 5 comments
Open

Compling with later versions of GHC #285

erikd opened this issue Nov 27, 2024 · 5 comments
Labels

Comments

@erikd
Copy link
Contributor

erikd commented Nov 27, 2024

Context

I have just got this package compiling with ghc-9.8 and got that PR merged. Most other things in the Cardano/Haskell stack already compiles with ghc-9.10. When I started trying to make this package compile with ghc-9.10 I ran into a number of sticky issues.

  • cardano-addresses depends on hjsonschema which is deprecated.
  • hjsonschema depends on protolude but I have removed that as a dependency from the rest of the tree, because protolude was poorly maintained.

What should we do about this? @Crypto2099 @paweljakubas .

@abailly
Copy link

abailly commented Nov 28, 2024

It's unclear to me what's the strategy w.r.t compilers support for this package: do we want to only support latest versions of GHC? Do we want to support several versions?

Also, I wonder what those dependencies you mention are used for.

@abailly
Copy link

abailly commented Nov 28, 2024

FWIW I have tried removing the dependency to hjsonschema and compile the code with 9.8.2 and 9.10.1 and it worked fine.

@erikd
Copy link
Contributor Author

erikd commented Nov 29, 2024

I think the aim is to compile with a wide range of compilers. Newer compilers tend to become standard compilers over time.

protolude is just an alternative Prelude and was pretty easy to remove the rest of our code base (involved cargo culting a small amount of functionality into cardano-base).

@erikd
Copy link
Contributor Author

erikd commented Nov 29, 2024

FWIW I have tried removing the dependency to hjsonschema and compile the code with 9.8.2 and 9.10.1 and it worked fine.

Is that something that we should consider and merge into master?

@abailly
Copy link

abailly commented Nov 29, 2024

Is that something that we should consider and merge into master?

Would love to but I am a newcomer around here, so not sure what purpose served hjsonschema. Perhaps @paweljakubas or @Crypto2099 or @disassembler would know better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants