Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The bot's version isn't retrieved directly from Github #14

Open
IkelosOne opened this issue Jul 15, 2021 · 3 comments
Open

The bot's version isn't retrieved directly from Github #14

IkelosOne opened this issue Jul 15, 2021 · 3 comments

Comments

@IkelosOne
Copy link
Collaborator

IkelosOne commented Jul 15, 2021

It would be good if the bot retrieved its version directly from the Github releases. Surely there's some git file we can use to get this information. If there is, then we can safely remove the version variable from the data file.

@ArunOsborn
Copy link
Collaborator

It's not garunteed the bot is running the latest release. For us, it should be, but its not garunteed. You'd have to cross reference the file and all releases on github which doesn't sound like its built into github.

@ArunOsborn
Copy link
Collaborator

I will consult Jack about this.

@IkelosOne
Copy link
Collaborator Author

It doesn’t matter if it’s the latest release or not (although we only do a release when we want Sirius III to run the code, so it should be the latest anyway). What I mean is that when you pull from GitHub you also pull a gitconfig file among other files. If these were included in a release (likely not since the release is just the clean working environment, whereas the pull is the messy git-ridden one) then we should be able to get the version number automatically. I’m not talking about doing a manual comparison of every file to see which commit matches the current directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants