Add a move bar widget #1627
Add a move bar widget #1627
Conversation
|
For reference, this is how the bar looks like |
This widget replaces the experimental move windows button that could be enabled from the Display Settings. That button was shown in the navigation bar and was a bit weird to use. This PR replaces it with a thing semi-transparent bar that when dragged moves the window in the horizontal direction as the old button used to do. That bar is unconditionally shown when in curved mode.
|
I fixed an error in the XML file that was preventing the navigation url bar being shown while in not curved mode |
|
I think that the move bar is still visible in resize mode, but it can not be used. It should probably be hidden in that case. |
I have tried and it is not visible, so working as expected. That said I found a weird bug. When putting a standard YT video in fullscreen mode and then unfullscreening it, the move bar dissapears from the front window. It's shown in the others but not in the front one. I'm checking. |
Window view model's isCurved property was not properly updated when exiting fullscreen. When entering fullscreen it's updated because placeWindow() is called. However on unfullscreen placeWindow() is not called so the isCurved property was not updated. The solution is to call updateCurvedMode when entering/exiting fullscreen.
The bug was not caused by the patch, but unveiled instead. I've included a commit that fixes it. |
app/src/common/shared/com/igalia/wolvic/ui/widgets/NavigationBarWidget.java
Show resolved
Hide resolved
This widget replaces the experimental move windows button that could be enabled from the Display Settings. That button was shown in the navigation bar and was a bit weird to use.
This PR replaces it with a thing semi-transparent bar that when dragged moves the window in the horizontal direction as the old button used to do. That bar is unconditionally shown when in curved mode.