Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] How should we deal with the total results when the sum of all weights is zero? #530

Open
ChiCheng45 opened this issue Aug 2, 2024 · 0 comments
Open

[BUG] How should we deal with the total results when the sum of all weights is zero? #530

ChiCheng45 opened this issue Aug 2, 2024 · 0 comments
Labels
bug Something isn't working question Further information is requested

Comments

@ChiCheng45
Copy link
Collaborator

ChiCheng45 commented Aug 2, 2024 •
edited
Loading

Description of the error
When the sum of all weights is zero, the total results will be nan due to the division by zero. This will cause a crash when you try to plot the total result. For example, this occurs with Ar36 trajectory and the b_inc weight since b_inc=0.
@ChiCheng45 ChiCheng45 added the bug Something isn't working label Aug 2, 2024
@ChiCheng45 ChiCheng45 changed the title [BUG] GUI crash when plotting total DISF for single-component systems [BUG] Crash when plotting total DISF for single-component systems Aug 2, 2024
@ChiCheng45 ChiCheng45 added the question Further information is requested label Aug 9, 2024
@ChiCheng45 ChiCheng45 changed the title [BUG] Crash when plotting total DISF for single-component systems [BUG] How should we deal with the total results when the sum of all weights is zero? Aug 9, 2024
@MBartkowiakSTFC MBartkowiakSTFC mentioned this issue Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChiCheng45