Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Roundup styles for Saved Links interfere with WordPress' emoji substitution #178

Open
4 tasks
benlk opened this issue May 29, 2019 · 0 comments
Open
4 tasks

Comments

@benlk
Copy link
Collaborator

benlk commented May 29, 2019

Following from #177, a Saved Link with the title "brittany renee 🌸 on Twitter" will be displayed with the following markup in the post:

<p class="lr-saved-link ">
	<a href="https://twitter.com/BritRenee_/status/1133459151655456769">
		brittany renee
		<img draggable="false" class="emoji" alt="🌸" src="https://s.w.org/images/core/emoji/12.0.0-1/svg/1f338.svg">
		on Twitter
	</a><span class="description">"Very Important Question: What's your favorite episode of your favorite tv show?! Right now, mine is Psych s7e11"</span>
	<em>Twitter</em>
</p>

In that markup, the image is inline.

And in Link Roundups' main CSS, it appears thusly:

Screen Shot 2019-05-28 at 19 08 16

img {
float: left;
margin: 0 1em 1em 0;
}

  • give that image a more-specific selector in the default Saved Link markup option
  • update CSS
  • check that it works for sites that have saved a different image markup in the Link Roundups settings
  • check that it works in the Saved Links List widget
@benlk benlk added this to the v1.1 milestone Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant